[Tests only] Expand trigger populated PK test case to run against more DBs #50794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
force-pushed
the
test-trigger-pk-population-against-more-dbs
branch
from
1427228
to
2457067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #50783
I realized that I unnecessarily limited one of the tests to postgresql while the fix should be applicable to any database that supports
RETURNINGstatement.Sadly I couldn't come up with a proper setup for sqlite since it looks like there is no way of updating
NEWrecord columns before insert in a trigger. So if someone has ideas on how to setup an sqlite trigger to generateidcolumn value before insert - the test case can be tested against sqlite. But for now it technically means we will be testing it on MariaDB in addition to postgresql