Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to modules_for_helpers documentation [ci-skip] #50808

Merged

Conversation

m-nakamura145
Copy link
Contributor

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the actionpack label Jan 19, 2024
@m-nakamura145 m-nakamura145 force-pushed the actionpack/modules_for_helpers-example branch from 4e99839 to e7007a0 Compare January 19, 2024 15:28
@m-nakamura145
Copy link
Contributor Author

@Edouard-chin Thank you!

@Edouard-chin
Copy link
Member

Arf sorry, I forgot the comment token # in my suggestion (Rubocop failing) 🤦 .

@m-nakamura145 m-nakamura145 force-pushed the actionpack/modules_for_helpers-example branch from e7007a0 to 0f106fb Compare January 19, 2024 15:47
@m-nakamura145 m-nakamura145 force-pushed the actionpack/modules_for_helpers-example branch from 0f106fb to 9306495 Compare January 19, 2024 15:49
@m-nakamura145
Copy link
Contributor Author

@Edouard-chin Fixed 👍

@Edouard-chin Edouard-chin merged commit 21eceb7 into rails:main Jan 19, 2024
3 checks passed
@m-nakamura145 m-nakamura145 deleted the actionpack/modules_for_helpers-example branch January 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants