Improve Rails console's IRB autocompletion control #50814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Setting `TERM=dumb` is enough to disable colorization in those tests. Mocked app should also load console helpers Move console method extension to IRBConsole's constructor Test IRB autocompletion control without mutating ENV Control IRB autocompletion without mutating ENV Correct local variable name
st0012
force-pushed
the
improve-rails-console
branch
from
c76dd69
to
4d6714f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This is a follow up PR for this comment and other small refactors.
Detail
I made small improvements on Rails console related tests and avoided using ENV to control IRB's autocompletion toggle. But none of the change should affect end users.
I explained each change in their own commits. I can also split them into another PRs if that's preferred.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]