Add ".[key]" to the abstract namespaces [ci skip] #50860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section "Error Message Scopes" describes how the Rails look up the namespaces for a validation error message with code snippets. The first code snippet shows abstract namespaces like `errors.attributes.[attribute_name]` while the second one demonstrates the materialized one like `errors.attributes.name.blank`. The first code snippet lacks the validation error "key." My team member was confused and created a translation without "key", so I think it would be helpful to add ".[key]" to the abstract namespaces.
skipkayhil
requested changes
Jan 27, 2024
guides/source/i18n.md
Outdated
| @@ -918,11 +918,11 @@ end | |||
| The key for the error message in this case is `:blank`. Active Record will look up this key in the namespaces: | |||
There was a problem hiding this comment.
I think the idea makes sense but now the example doesn't fit with this line introducing it. When .[key] is included the list is no longer a list of namespaces, its a list of the exact keys going to be checked
There was a problem hiding this comment.
Thank you for your advice. It makes sense. I updated with 6f56e37, and moved abstract list after :blank examples. Besides, I changed the wording.
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
* Add ".[key]" to the abstract namespaces [ci skip] The section "Error Message Scopes" describes how the Rails look up the namespaces for a validation error message with code snippets. The first code snippet shows abstract namespaces like `errors.attributes.[attribute_name]` while the second one demonstrates the materialized one like `errors.attributes.name.blank`. The first code snippet lacks the validation error "key." My team member was confused and created a translation without "key", so I think it would be helpful to add ".[key]" to the abstract namespaces. * Move abstract key list after :blank examples Co-authored-by: Rafael Mendonça França <rafael@rubyonrails.org>
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
* Add ".[key]" to the abstract namespaces [ci skip] The section "Error Message Scopes" describes how the Rails look up the namespaces for a validation error message with code snippets. The first code snippet shows abstract namespaces like `errors.attributes.[attribute_name]` while the second one demonstrates the materialized one like `errors.attributes.name.blank`. The first code snippet lacks the validation error "key." My team member was confused and created a translation without "key", so I think it would be helpful to add ".[key]" to the abstract namespaces. * Move abstract key list after :blank examples Co-authored-by: Rafael Mendonça França <rafael@rubyonrails.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The section "Error Message Scopes" describes how the Rails look up the namespaces for a validation error message with code snippets. The first code snippet shows abstract namespaces like
errors.attributes.[attribute_name]while the second one demonstrates the materialized one likeerrors.attributes.name.blank. The first code snippet lacks the validation error "key." My team member was confused and created a translation without "key", so I think it would be helpful to add ".[key]" to the abstract namespaces.Checklist
Before submitting the PR make sure the following are checked:
[ ] This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.[Fix #issue-number][ ] Tests are added or updated if you fix a bug or add a feature.[ ] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.