Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert help on unrecognized bare options #50878

Merged

Conversation

djensenius
Copy link
Contributor

Motivation / Background

This Pull Request has been created because #50798 created issues when running with --trace.

Detail

This Pull Request reverts changes in #50798 and adds a test for --trace which failed in the aforementioned PR.

Additional information

We specifically ran into trouble when running bin/rails --trace db:test:prepare.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label Jan 25, 2024
@rafaelfranca rafaelfranca merged commit 9a5c680 into rails:main Jan 25, 2024
4 checks passed
@djensenius djensenius deleted the revert-help-on-unrecongized-commands branch January 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants