New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uniform spacing in 7.1 new framework defaults #50880

Merged

rafaelfranca merged 1 commit into rails:7-1-stable from Earlopain:framework-defaults-rubocop

Jan 25, 2024

Contributor

Earlopain commented Jan 25, 2024

Only the last five entries have two newlines between them and I can't see a good reason for that, see #49546.

In addition to being inconsistent this trips RuboCop with Layout/EmptyLines which is enabled by default.


          Use uniform spacing in new framework defaults

054edea

This supresses the `Layout/EmptyLines` RuboCop cop which is enabled by default

rails-bot bot added the railties label

rafaelfranca merged commit 5ed3893 into rails:7-1-stable

3 of 4 checks passed

Earlopain deleted the framework-defaults-rubocop branch

January 25, 2024 22:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment