Commented out lines in .railsrc file should not be treated as arguments #50904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williantenfen
force-pushed
the
support-comments-on-railsrc-file
branch
from
13c5e77
to
6887894
Compare
|
buildkite failure not related... seems like actioncable integration spec couldn't launch firefox 63 |
rafaelfranca
force-pushed
the
support-comments-on-railsrc-file
branch
from
6887894
to
ba214df
Compare
Commented out lines in .rc file should not be treated as arguments when using rails new generator command. [Fix rails#50899]
rafaelfranca
force-pushed
the
support-comments-on-railsrc-file
branch
from
ba214df
to
35f132e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out lines in .rc file should not be treated as arguments when using rails new generator command.
Motivation / Background
This Pull Request has been created because railsrc file doesn't handles commented out lines (
#)Issue #50899
Detail
This Pull Request changes Railtie ARGVScrubber to ignore text after
#symbolsAdditional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]