Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error in the document for query_constraints [ci-skip] #50936

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Feb 1, 2024

Motivation / Background

Found a documentation that did not make sense to me on the first look. The context of this example suggests what it really wants to point to is query_constraints instead of query_by.

Also applied the fixed-width font to the reference to the methods correctly. Since both of these changes belong to the docs of the same method, I have packed them in one commit.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

The context of this example suggests what it really wants to
point to is `query_constraints` instead of `query_by`.

Also apply fixed-width font to the reference to the methods correctly.
@carlosantoniodasilva carlosantoniodasilva merged commit e09e61a into rails:main Feb 1, 2024
3 checks passed
carlosantoniodasilva added a commit that referenced this pull request Feb 1, 2024
Correct error in the document for `query_constraints` [ci-skip]
@sato11 sato11 deleted the query-constraints-typo branch February 1, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants