Tiny update to callbacks docs [ci skip] #50952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The following was added to the
ActiveJob::Callbacks
,ActiveModel::Callbacks
andAbstractController:Callbacks
docs in #29072:The comment refers to "calling" callbacks but seems to be about defining callbacks, as mentioned in the PR description.
In the ActiveJob and AbstractController docs, I believe this will be misinterpreted as referring to setting callbacks, which, as far as I can tell, does not have such a restriction.
In the ActiveModel docs, I believe it would be slightly clearer to replace "calling" with "defining".
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]