Deprecate config.active_record.warn_on_records_fetched_greater_than #51007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
Feb 9, 2024
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
hundredwatt
force-pushed
the
deprecate-config.active_record.warn_on_records_fetched_greater_than
branch
from
e2e7145
to
48112e9
Compare
hundredwatt
deleted the
deprecate-config.active_record.warn_on_records_fetched_greater_than
branch
Ridhwana
pushed a commit
to Ridhwana/rails
that referenced
this pull request
Mar 7, 2024
…ails#51007) * Deprecate config.active_record.warn_on_records_fetched_greater_than * Review changes Co-authored-by: Rafael Mendonça França <rafael@franca.dev> --------- Co-authored-by: Jason Nochlin <hundredwatt@users.noreply.github.com> Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
…ails#51007) * Deprecate config.active_record.warn_on_records_fetched_greater_than * Review changes Co-authored-by: Rafael Mendonça França <rafael@franca.dev> --------- Co-authored-by: Jason Nochlin <hundredwatt@users.noreply.github.com> Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
…ails#51007) * Deprecate config.active_record.warn_on_records_fetched_greater_than * Review changes Co-authored-by: Rafael Mendonça França <rafael@franca.dev> --------- Co-authored-by: Jason Nochlin <hundredwatt@users.noreply.github.com> Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate config.active_record.warn_on_records_fetched_greater_than setting in favor of #50887.
The same functionality (and more) can now be achieved by subscribing to sql.active_record notifications:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]