Gracefully handle transactional fixtures leaks #51010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
handle-transactional-fixtures-leak
branch
2 times, most recently
from
d99784a
to
5af2f73
Compare
Extracted from: rails#50999 Some tests may use the connections in ways that cause the fixtures transaction to be committed or rolled back. The typical case being doing schema change query in MySQL, which automatically commits the transaction. But ther eare more subtle cases. The general idea here is to ensure our transaction is correctly rolling back during teardown. If it fails, then we assume something might have mutated some of the inserted fixtures, so we invalidate the cache to ensure the next test will reset them. This issue is particularly common in Active Record's own test suite since transaction fixtures are enabled by default but we have many tests create tables and such. We could treat this case as an error, but since we can gracefully recover from it, I don't think it's worth it.
casperisfine
force-pushed
the
handle-transactional-fixtures-leak
branch
from
5af2f73
to
26de25d
Compare
|
Looks like this PR introduced some noise to the Postgres tests output https://buildkite.com/rails/rails/builds/104728#018d9028-611d-481d-930b-4f7a31a4f9c0 |
|
Yeah, I noticed that in #50999 (comment), and it will fix it once merged. I'll likely merge it tomorrow. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from: #50999
Some tests may use the connections in ways that cause the fixtures transaction to be committed or rolled back. The typical case being doing schema change query in MySQL, which automatically commits the transaction. But ther eare more subtle cases.
The general idea here is to ensure our transaction is correctly rolling back during teardown. If it fails, then we assume something might have mutated some of the inserted fixtures, so we invalidate the cache to ensure the next test will reset them.
This issue is particularly common in Active Record's own test suite since transaction fixtures are enabled by default but we have many tests create tables and such.
We could treat this case as an error, but since we can gracefully recover from it, I don't think it's worth it.