Properly synchronize Mysql2Adapter#active? and TrilogyAdapter#active?
#51012
+99
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
fix-thread-safety-in-mysql-adapters
branch
from
3e50b8e
to
6c4178d
Compare
…ve?` As well as `disconnect!` and `verify!`. This generally isn't a big problem as connections must not be shared between threads, but is required when running transactional tests or system tests and could lead to a SEGV.
casperisfine
force-pushed
the
fix-thread-safety-in-mysql-adapters
branch
from
6c4178d
to
6f3b46b
Compare
|
Nice find, Jean. I think this fixes the problem we were seeing in our CI. Do you plan to backport this to 7.1 or 7.0? Going to apply a monkey patch in the meantime. |
|
Hum, I didn't backport because I didn't think it was possible to run into in outside of #50999. But you guys set the |
byroot
added a commit
that referenced
this pull request
Feb 9, 2024
…pters Properly synchronize `Mysql2Adapter#active?` and `TrilogyAdapter#active?`
|
Backported to
|
|
It’s ok. We’re going to 7.1 very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as
disconnect!andverify!.This generally isn't a big problem as connections must not be shared between threads, but is required when running transactional tests or system tests and could lead to a SEGV.
Found while working on #50999