Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make various minor fixes to the Active Record test suite #51021

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

casperisfine
Copy link
Contributor

Extracted from: #50999

  • Make fixtures setup and teardown methods private.
  • Don't run adapter thread safety tests with sqlite3_mem
  • Make foreign_key_tests more resilient to leaked state
  • Use exit! in fork to avoid at_exit side effects.
  • Disable transactional fixtures in tests that do a lot of low level assertions on connections or connection pools.

Extracted from: rails#50999

- Make fixtures setup and teardown methods private.
- Don't run adapter thread safety tests with sqlite3_mem
- Make foreign_key_tests more resilient to leaked state
- Use `exit!` in fork to avoid `at_exit` side effects.
- Disable transactional fixtures in tests that do a lot of low level
  assertions on connections or connection pools.
@byroot byroot merged commit f5ea4a5 into rails:main Feb 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants