Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoMethodErrors in Active Record after backport [7-1-stable] #51027

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix NoMethodErrors in Active Record after backport [7-1-stable] #51027

merged 2 commits into from
Feb 9, 2024

Conversation

skipkayhil
Copy link
Member

@skipkayhil skipkayhil commented Feb 9, 2024 •
edited

Ref #51012

connected? only exists on main, but was included in a backport

cc @byroot

@skipkayhil
Fix NoMethodError in MySQL Adapters
6bf07fa 
connected? only exists on main, but was included in a [backport][1]

[1]: eb760da
@skipkayhil
Copy link
Member Author

Looks like the backport of #50983 is also broken... I'll see if I can find the fix and just add it to this PR

@skipkayhil
Fix "undefined method to_sym" after backport
b896104 
The [backport][1] of a [fix][2] for CPK + counter_cache did not remove
calling `to_sym` on the `foreign_key` of the association, so it raised
an error because `foreign_key` is now an array.

[1]: 26aa77d
[2]: ea38048
@skipkayhil skipkayhil changed the title Fix NoMethodError in MySQL Adapters Fix NoMethodErrors in Active Record after backport [7-1-stable] Feb 9, 2024
@byroot
Copy link
Member

byroot commented Feb 9, 2024

Arf, thank you.

@byroot byroot merged commit aff2e00 into rails:7-1-stable Feb 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skipkayhil @byroot