Remove initializer that was eager loading the schema cache dump #51034
Conversation
| Configure the `:schema_cache_path` in the database configuration instead. | ||
| MSG | ||
|
|
||
| nil |
There was a problem hiding this comment.
Shouldn't this return ENV["SCHEMA_CACHE"]? Deprecated doesn't mean it should have no effect. No?
There was a problem hiding this comment.
Even if it return something, it would not have any effect. The loading of the schema cache doesn't use this environment variable, so unfortunately we will need to make a breaking change. I could raise, but if I return nil things would just work. In a different file path, but still work.
Only when schema cache is present and check_schema_cache_dump_version is false.
This allow us to be explicit about the environment we want to load.
This will be eager loaded by the define_attribute_methods initializer now that the schema cache can be automatically loaded for all connection if the file is present on disk after #48716.
The message was partially duplicated because `deprecation_warning` was being called instead of `warn`
…he databse configuration The config in the yaml allows for more complex configuration.
rafaelfranca
force-pushed
the
rm-schema-cache-loading
branch
from
f90e16f
to
f91cb4f
Compare
|
Thanks for the quick update here @rafaelfranca!! Do you anticipate back-porting this to |
|
It should not be necessary to backport. This is mostly a performance improvement, because the code to load schema cache should just work in 7.1 |
This will be eager loaded by the
define_attribute_methodsinitializer now that the schema cache can be automatically loaded for all connection if the file is present on disk after #48716.