ActionDispatch::Executor: report errors handled by ShowExceptions #51050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
show-exception-report-error
branch
2 times, most recently
from
6f6a48a
to
254a4cb
Compare
Fix: rails#51002 In the default middleware stack, the `ShowExceptions` middleware is lower than `ActionDispatch::Execturor` and will handle most exceptions causing `Executor` not to witness any. Instead we need to rely on `action_dispatch.exception` being added into the request env.
casperisfine
force-pushed
the
show-exception-report-error
branch
from
254a4cb
to
4067c95
Compare
byroot
added a commit
that referenced
this pull request
Feb 12, 2024
ActionDispatch::Executor: report errors handled by ShowExceptions
byroot
added a commit
that referenced
this pull request
Feb 12, 2024
ActionDispatch::Executor: report errors handled by ShowExceptions
Done. |
|
Can confirm this fixes the original issue- thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #51002
In the default middleware stack, the
ShowExceptionsmiddleware is lower thanActionDispatch::Execturorand will handle most exceptions causingExecutornot to witness any.Instead we need to rely on
action_dispatch.exceptionbeing added into the request env.FYI @fractaledmind @rafaelfranca
To be backported to 7.1 and 7.0.