Raise error for Trilogy when prepared_statements is true
#51072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trilogy doesn't currently support prepared statements. The error that applications would see is a `StatementInvalid` error. This doesn't quite point you to the fact this isn't supported. So raise a more appropriate error pointing to what to change.
eileencodes
force-pushed
the
raise-error-for-trilogy-and-prepared-statements
branch
from
48e28ae
to
847953d
Compare
|
I'm backporting this because the error message doesn't make it clear that the problem is prepared statements are not supported by Trilogy. |
eileencodes
deleted the
raise-error-for-trilogy-and-prepared-statements
branch
eileencodes
added a commit
that referenced
this pull request
Feb 13, 2024
Trilogy doesn't currently support prepared statements. The error that applications would see is a `StatementInvalid` error. This doesn't quite point you to the fact this isn't supported. So raise a more appropriate error pointing to what to change. Manual backport of #51072 due to conflicts.
|
@eileencodes Do you know if this is still accurate? The Trilogy README explicitly says:
|
|
@eileencodes Ah, sorry, I realize that is for the C library not the Ruby adapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trilogy doesn't currently support prepared statements. The error that applications would see is a
StatementInvaliderror. This doesn't quite point you to the fact this isn't supported. So raise a more appropriate error pointing to what to change.