Don't force controller or integration tests to load #51150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2730f10 replaced references to ActionController::TestCase and ActionDispatch::IntegrationTest in this file with lazy load hooks to avoid loading them prematurely, but these requires meant that they were still loaded anyway.
| @@ -7,9 +7,6 @@ | |||
| abort("Abort testing: Your Rails environment is running in production mode!") if Rails.env.production? | |||
|
|
|||
| require "active_support/test_case" | |||
| require "action_controller" | |||
| require "action_controller/test_case" | |||
| require "action_dispatch/testing/integration" | |||
There was a problem hiding this comment.
This removal broke our tests at github. We have been including Rails::Dom::Testing::Assertions in our BasicTestCase class to use dom assertions like assert_select. To fix that I had to manually require "rails-dom-testing". I think it is good that we are loading less stuff by default, but I'm wondering whether it is worth or not a CHANGELOG entry.
There was a problem hiding this comment.
No need for changelog. The fact that "rails-dom-testing" was already loaded by rails/test_help was never documented as a feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32776 replaced references to
ActionController::TestCaseandActionDispatch::IntegrationTestin this file with lazy load hooks to avoid loading them prematurely, but these requires meant that they were still loaded anyway.Aside from the direct benefit of loading as little as possible until necessary, this will allow users of https://github.com/amatsuda/routes_lazy_routes to run e.g. a model test without loading the application's routes, which can reduce boot time significantly for large applications.