clear_query_caches_for_current_thread: avoid pinning all connections #51151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rails#51083 (comment) Now that the pool is owned by the pool, we can clear it without hacing to checkout a connection.
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Feb 26, 2024
Was fixed upstream in rails#51151
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Feb 29, 2024
Ref: Shopify/maintenance_tasks#983 (comment) Ref: rails#51151 Now that query caches are owned by the pool, and assigned on connections during checkout, when running multithreaded code inside transactional tests (typically system tests), the two threads uses the same connection but not the same cache. So it's important that we do clear the caches for all threads when a connection is pinned.
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
Ref: Shopify/maintenance_tasks#983 (comment) Ref: rails#51151 Now that query caches are owned by the pool, and assigned on connections during checkout, when running multithreaded code inside transactional tests (typically system tests), the two threads uses the same connection but not the same cache. So it's important that we do clear the caches for all threads when a connection is pinned.
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
Ref: Shopify/maintenance_tasks#983 (comment) Ref: rails#51151 Now that query caches are owned by the pool, and assigned on connections during checkout, when running multithreaded code inside transactional tests (typically system tests), the two threads uses the same connection but not the same cache. So it's important that we do clear the caches for all threads when a connection is pinned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #51083 (comment)
Now that the query_cache is owned by the pool, we can clear it without having to checkout a connection.
cc @matthewd @bensheldon