Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF-DOCS] Action View Overview Guide [ci-skip] #51435

Merged

Conversation

bhumi1102
Copy link
Contributor

@bhumi1102 bhumi1102 commented Mar 28, 2024

Motivation / Background

This Pull Request is for updating and improving the Action View Overview guide.

Note: This guide was intertwined with a different guide (Layouts and Rendering) with duplicate content and overlapping concepts. A follow-on PR will focus on the other guide and then we will do a pass over both guides together.

Details

  • Add more code examples and update existing examples.
  • Consolidate all topics related to partials in this guide.
  • Restructure sections for better flow and readability
  • Reword the introduction and clarify how Action View fits in

Testing

  • Run guides:generate
  • Run guides:lint
  • Run rubocop on code samples

bhumi1102 and others added 30 commits February 27, 2024 11:56
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
bhumi1102 and others added 3 commits March 28, 2024 09:32
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
@rails-bot rails-bot bot added the docs label Mar 28, 2024
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
@p8 p8 added the rails foundation Rails Foundation PRs label Mar 29, 2024
Copy link
Member

@p8 p8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@asavageiv asavageiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
bhumi1102 and others added 4 commits April 4, 2024 12:52
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Alan Savage <asavageiv@users.noreply.github.com>
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
bhumi1102 and others added 3 commits April 8, 2024 14:06
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Erick Sasse <148989+esasse@users.noreply.github.com>
@carlosantoniodasilva carlosantoniodasilva self-assigned this Apr 8, 2024
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhumi1102 the flow of this guide is super nice, great work with these updates! I had a just a few minor suggestions / nitpicks below, and I'm looking into the "builder" question, will report back. (we might go ahead with the merge without waiting on that, and change later as needed)

Let me know if you have any questions.

guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Outdated Show resolved Hide resolved
guides/source/action_view_overview.md Show resolved Hide resolved
bhumi1102 and others added 2 commits April 11, 2024 13:36
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
@bhumi1102
Copy link
Contributor Author

@bhumi1102 the flow of this guide is super nice, great work with these updates! I had a just a few minor suggestions / nitpicks below, and I'm looking into the "builder" question, will report back. (we might go ahead with the merge without waiting on that, and change later as needed)

Let me know if you have any questions.

Thank you for re-reviewing @carlosantoniodasilva! I've pushed those final updates.

I agree we can merge and update the link for the "builder" question later if needed. Thanks for looking into that one.

@carlosantoniodasilva carlosantoniodasilva merged commit 73d692f into rails:main Apr 11, 2024
3 checks passed
carlosantoniodasilva added a commit that referenced this pull request Apr 22, 2024
After reviewing the Action View Overview guide, a discussion started
around the builder gem that was detailed in the guide. We decided to
move it to the rails/ umbrella so we can help maintain it as needed,
since the framework uses/documents it, keeping it similar to jbuilder.

#51435 (comment)
carlosantoniodasilva added a commit that referenced this pull request Apr 22, 2024
After reviewing the Action View Overview guide, a discussion started
around the builder gem that was detailed in the guide. We decided to
move it to the rails/ umbrella so we can help maintain it as needed,
since the framework uses/documents it, keeping it similar to jbuilder.

#51435 (comment)

cherry-pick of d462fb5 from main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rails foundation Rails Foundation PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants