New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF-DOCS] Action View Overview Guide [ci-skip] #51435
[RF-DOCS] Action View Overview Guide [ci-skip] #51435
Conversation
This reverts commit 9b7d3a8.
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com> Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com> Co-authored-by: Petrik de Heus <petrik@deheus.net> Co-authored-by: Alan Savage <asavageiv@users.noreply.github.com>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Erick Sasse <148989+esasse@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhumi1102 the flow of this guide is super nice, great work with these updates! I had a just a few minor suggestions / nitpicks below, and I'm looking into the "builder" question, will report back. (we might go ahead with the merge without waiting on that, and change later as needed)
Let me know if you have any questions.
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Thank you for re-reviewing @carlosantoniodasilva! I've pushed those final updates. I agree we can merge and update the link for the "builder" question later if needed. Thanks for looking into that one. |
After reviewing the Action View Overview guide, a discussion started around the builder gem that was detailed in the guide. We decided to move it to the rails/ umbrella so we can help maintain it as needed, since the framework uses/documents it, keeping it similar to jbuilder. #51435 (comment)
After reviewing the Action View Overview guide, a discussion started around the builder gem that was detailed in the guide. We decided to move it to the rails/ umbrella so we can help maintain it as needed, since the framework uses/documents it, keeping it similar to jbuilder. #51435 (comment) cherry-pick of d462fb5 from main.
Motivation / Background
This Pull Request is for updating and improving the Action View Overview guide.
Note: This guide was intertwined with a different guide (Layouts and Rendering) with duplicate content and overlapping concepts. A follow-on PR will focus on the other guide and then we will do a pass over both guides together.
Details
Testing
guides:generate
guides:lint