Fix for #5200 #5210
Closed
Fix for #5200 #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't merge properly any longer, mind updating it for HEAD? |
|
Ok, I merged the changes. Let me know if you need anything else from me. thanks! |
|
I'm not allowed to merge this, but yes, it merges cleanly now, thanks! It's all in @tenderlove or @jonleighton's hands now. |
|
3 months old PR, the fix looks straightforward, tests are included. Can we get some love from AR? |
|
This seems fine, but needs a rebase. |
…e were multiple belongs_to associations with the same foreign key.
|
@rafaelfranca I rebased it. Please let me know if you need anything else. thanks. |
rafaelfranca
added a commit
that referenced
this pull request
Aug 21, 2012
|
Done |
rafaelfranca
added a commit
that referenced
this pull request
Aug 21, 2012
Fix for #5200 Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb
MacksMind
added a commit
to MacksMind/rails
that referenced
this pull request
Mar 17, 2013
PR rails#5210 added a Friendship model to illustrate a bug, but in doing so created a confusing structure because both belongs_to declarations in Friendship referred to the same side of the join. The new structure maintains the integrity of the bug test while changing the follower relationship to be more useful for other testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset_counters() was crashing when there were multiple belongs_to associations with the same foreign key.. with only one of the belongs_to associations having a custom counter_cache.
reset_counters() made the false assumption that each belongs_to association has a counter_cache.