Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow code conventions on ActiveRecord tests #523

Closed
wants to merge 1 commit into from

Conversation

guilleiguaran
Copy link
Member

Following with #503 (by @smartinez87), I changed "something=>other" to "something => other" on ActiveRecord tests

@guilleiguaran
Copy link
Member Author

Also I notice that there are some tests using Model.find(:all) and Model.find(:first) instead of Model.all and Model.first, these must be changed?

@brajadorable
Copy link

Have you seen the comment on #503 ??

Also here #498

@josevalim
Copy link
Contributor

Exactly, thanks for the pull request but such changes just break old patches and pull requests while there is no explicit benefit in merging them.

@josevalim josevalim closed this May 12, 2011
@guilleiguaran
Copy link
Member Author

@brajadorable @josevalim. I haven't read the comments and you are right. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants