Fixes #5324 by removing default size options from input:text and default cols and rows options from textarea. #5366
Conversation
… default cols and rows options from textarea.
|
I think this is a step forward. /cc @chriseppstein @fxn @jeremy |
|
Sounds good :) Only one question: should the options be completely removed, or should the options be cleared to allow the user to set the same defaults back, in case they rely on - or want - them? |
|
It may break the look & feel of existing apps, but I think this is OK for a major version. The only thing I'd add is a note about this in the upgrading guide, so that people know they have to watch out for this change, rather than magically have their views looking weird. |
|
Agree with @fxn and that this is not something that should be in the rails helper. |
| @@ -757,7 +757,7 @@ def file_field(object_name, method, options = {}) | |||
| # # </textarea> | |||
| # | |||
| # text_area(:application, :notes, :cols => 40, :rows => 15, :class => 'app_input') | |||
| # # => <textarea cols="40" rows="15" id="application_notes" name="application[notes]" class="app_input"> | |||
| # # => <textarea rows="15" id="application_notes" name="application[notes]" class="app_input"> | |||
There was a problem hiding this comment.
Because the example specifies :rows
There was a problem hiding this comment.
Ah it also specifies :cols my bad, will fix.
|
This also need a CHANGELOG entry. Please let me know once everything is into place. |
…, rows from text_area helper.
|
@josevalim I've just pushed a change to the actionpack changelog. Hope it's appropriate! :-) |
Fixes #5324 by removing default size options from input:text and default cols and rows options from textarea.
Rails 4 no longer sets default values for `size`, `cols` and `rows` on `input`, `textarea` tags. See rails/rails@3384ee2 (part of rails/rails#5366) Signed-off-by: Alex Coles <alex@alexbcoles.com>
I'm sure this will be a controversial change :-)
But this reduces hardcoded HTML and makes default HTML easier to add CSS to (in my opinion) and has the added benefit of reducing the amount of HTML that is sent to the browser.
See issue #5324 for more reasoning.
Thanks!