Add separator option to grouped_options_for_select #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tenderlove @josevalim Any thoughts on this? |
| @@ -476,13 +476,23 @@ def option_groups_from_collection_for_select(collection, group_method, group_lab | |||
| # | |||
| # <b>Note:</b> Only the <tt><optgroup></tt> and <tt><option></tt> tags are returned, so you still have to | |||
| # wrap the output in an appropriate <tt><select></tt> tag. | |||
| def grouped_options_for_select(grouped_options, selected_key = nil, prompt = nil) | |||
There was a problem hiding this comment.
The signature can be (grouped_options, selected_keys, options={}). If someone pass something different than a hash as options, he's passing the prompt so we should show a deprecation warning.
|
That's a good point, I'll work on making prompt part of the options hash and deprecating it as an argument. |
Change prompt to options hash in grouped_options_for_select
|
@josevalim @isaacsanders I've added the prompt as part of the options hash and added a deprecation warning. Let me know what you think. |
tenderlove
added a commit
that referenced
this pull request
May 16, 2012
…tions_for_select Add separator option to grouped_options_for_select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a separator option to the method grouped_options_for_select if provided.
This is a common use case that people are often using optgroups for –– As a way of dividing options in a select.
This is a revision of my earlier pull request:
#5363