ConnectionPooll#clear_active_connections! rdoc inaccuracy since 3.2.0 #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad threads, it doesn't since 3.2.0
tenderlove
added a commit
that referenced
this pull request
Mar 12, 2012
ConnectionPooll#clear_active_connections! rdoc inaccuracy since 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tenderlove, believe clear_active_connections! stopped checking for connections checked out to dead threads in 3.2.0, but it's inline comment rdoc still says it does. Needs to be fixed to be accurate and not mislead developers trying to figure out what's up.
This needs to be committed to master too, I think, but only pull requesting for 3-2-stable. Let me know what preferred practices are for sending a pull request that needs to go to a release branch and to master both.
thanks!