Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mailer generator to use 1.9 styled hash when run on Ruby 1.9 #540

Merged
merged 1 commit into from May 13, 2011

Conversation

sikachu
Copy link
Member

@sikachu sikachu commented May 13, 2011

This is per @dhh request as to complete the 1.9 generator series

@asanghi
Copy link
Contributor

asanghi commented May 13, 2011

Are we already changing all the guides to reflect the 1.9 hash format? /cc @fxn

@sikachu
Copy link
Member Author

sikachu commented May 13, 2011

We aren't, and I'm going to submit a patch for that today. :)

@josevalim
Copy link
Contributor

@sikachu, could you please provide a pull request without changing the guides? I don't think we should change the guides yet as we still support 1.8.7. Thanks! /cc @fxn

As always, you can run `--old-style-hash` to override that.
@sikachu
Copy link
Member Author

sikachu commented May 13, 2011

Commit updated

josevalim added a commit that referenced this pull request May 13, 2011
Update Mailer generator to use 1.9 styled hash when run on Ruby 1.9
@josevalim josevalim merged commit 0307fc7 into rails:master May 13, 2011
jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants