Commas in directory names causes hang in ActiveSupport::FileUpdateChecker #5445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Could you please:
|
|
Wow, quick response, I will do so, do you have a suggestion on a way to do this without fork? Or is the test suite freezing preferable for windows compatible? (only on fail) |
|
Shouldn't all the Dir.glob characters be escaped? |
|
Probably, I have only proved that comma's trigger this issue though. |
|
Jon, maybe you can span a thread? Timeout should work fine with threads. |
|
As requested, now based off master #5448 |
|
Moving discussion to #5448. Note that the fork code in this test patch is actually flawed anyway (no cleanup of stuck processes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having commas in directory names passed through to ActiveSupport::FileUpdateChecker causes an infinite hang whilst Dir[@glob] tries and fails to list files in these directories. This wasn't an issue before ~> 3.2 but on 3.2 upwards it prevents Rails from booting in development mode and prevents test suites running (rspec, cucumber at least).
Commas are perfectly valid parts of directory names (on OS X at least) and escaping them when compiling the glob solves this issue.
This issue can be triggered by adding such directories to the autoload component of rails config see: https://github.com/JonRowe/rails-broken-dir-example for an example broken application.