Strip null bytes from Location header #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for stripping \r\n chars since that's already happening
tenderlove
added a commit
that referenced
this pull request
Mar 15, 2012
Strip null bytes from Location header
tenderlove
added a commit
that referenced
this pull request
Mar 15, 2012
Strip null bytes from Location header
tenderlove
added a commit
that referenced
this pull request
Mar 15, 2012
Strip null bytes from Location header
tenderlove
added a commit
that referenced
this pull request
Mar 15, 2012
Strip null bytes from Location header Conflicts: actionpack/test/controller/redirect_test.rb
| end | ||
|
|
||
| def test_redirect_with_null_bytes | ||
| get :redirect_with_header_break |
There was a problem hiding this comment.
Hey, I think this should read redirect_with_null_bytes instead, not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips null bytes off of the
Locationheader in addition to\r\nwhich are already being stripped.This is in response to a recent nasty security vulnerability in nginx. I figure it's probably easier for people to get this patch in their Rails applications than it is for them to get nginx upgraded in their infrastructure - which may or may not even be managed by them.
I'd like to get this into all supported Rails versions, not sure if this patch will apply cleanly to 3.1 or 3.0 - let me know if not and I'll send some others.