Fix build for branch 3-0-stable - failing in ruby 1.8.8-p358 #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the hash ordering changes on Ruby 1.8.7-p358.
josevalim
added a commit
that referenced
this pull request
Mar 27, 2012
Fix build for branch 3-0-stable - failing in ruby 1.8.8-p358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failing tests related to form options, and a random issue that happens with rjs tests, all related to Ruby 1.8.7-p358. I had to change a little bit the implementation of the FixtureResolver to avoid calling
hash.select {}.each- it also is more similar to the implementation in 3-1 forward.These rjs tests were completely removed in 3-1 together with
render :update. And I didn't find any other test that uses FixtureResolver relying on ordering like this one.Let me know if something needs improvement. Thanks.