Typecast 'id' attribute in read_attribute when using custom pks #5661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
added a commit
that referenced
this pull request
Mar 30, 2012
Typecast 'id' attribute in read_attribute when using custom pks
|
Doh, I didn't realise I had broken the build! Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this awesome cleanup ❤️.
When using custom primary keys, the
idattribute works as an alias to the pk. But in case of read_attribute, when reading theidit was not being typecasted after the change.Also added a deprecation message to
type_cast_codeaccording to the conversation in the same commit.Thanks!