Remove sort on attributes.keys #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm agreed, no need for sorting at all. /cc @josevalim |
|
On the other hand, sorting doesn't hurt and gives a nice consistency in the output. |
|
Yeah agreed, it doesn't hurt.. but in the case of consistency, unsure if only attributes sorting would be enough, given it adds methods and associations after the attributes. Anyway, ok to close it so? |
|
@josevalim @carlosantoniodasilva it's not consistent with the underlying data model, nor any other form of ActiveModel/Record introspection methods. You guys are much more familiar with the code base than I, but I think this is the only time the attributes are represented as a sorted set. |
|
@josevalim @carlosantoniodasilva do we have a definition for this pull request? |
carlosantoniodasilva
added a commit
that referenced
this pull request
May 19, 2012
Remove sort on attributes.keys
gaurish
referenced
this pull request
Aug 18, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't find a reason the keys are sorted and my preference would be for the hash to be remain in whatever order the attributes hash is.