Add role inheritance to attr_accessible #5699
Conversation
|
|
||
| self._accessible_attributes = accessible_attributes_configs.dup | ||
|
|
||
| Array(role).each do |name| | ||
| self._accessible_attributes[name] = self.accessible_attributes(name) + args | ||
| role = inherited_role || name # Use name role if inherited_role doesn't exist |
There was a problem hiding this comment.
From your example above you pass both :as => :admin and :inherits => :default, but here you are overwriting role if inherited_role was passed. Doesn't that make it meaningless to pass the :as option?
There was a problem hiding this comment.
I don't think so, because you still need the :as to access the role. I tested the overwriting in a live application to make sure it didn't mess anything up, and it works perfectly.
There was a problem hiding this comment.
Also it's not overwriting any original roles, the Array(role).each is looping through all the given attributes for that role, then if there is an inherited role it will gather those attributes as well, then the + args below will gather the current roles attributes.
|
I like the idea. Not very much the API though. This would avoid adding a new parameter and allow multiple inheritance. |
|
I don't think much can be done with this until after the details on the strong_parameters implementation are hashed out. I believe the model assignment security is going to be factored out into a gem at some point, IIRC. |
|
@dmathieu Actually that's already available and I didn't know that at the time I wrote this up. I'll close this since you can already do something similar by just using an array in the Thanks for the comments! |
I noticed when making pretty complex applications with a lot of attributes and roles, that the attr_accessible list gets copied a lot, and just isn't very DRY. Adding an inheritance option to attr_accessible enables developers to clearly see the attributes being inherited to the role.