Removes caching from ActiveRecord::Core::ClassMethods#relation #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'"
| @@ -1099,6 +1099,10 @@ def test_unscoped_block_style | |||
| assert_equal 'honda', FastCar.unscoped { FastCar.order_using_old_style.limit(1).first.name} | |||
| end | |||
|
|
|||
| def test_unscoped_relation_clones | |||
| assert_not_equal CoolCar.unscoped.object_id, CoolCar.unscoped.object_id | |||
…coped (as described in #5667)
|
@jeremy I changed the test to resemble the remaining issue described in #5667. Is it okay or do you want me to change anything else? /cc @jonleighton |
jeremy
added a commit
that referenced
this pull request
Apr 8, 2012
Removes caching from ActiveRecord::Core::ClassMethods#relation
|
Thanks @benedikt ! |
This was referenced Apr 19, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#relationmethod gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone wasActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place.The four places with calls to relations are: