Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigdecimal dup #5800

Merged
merged 3 commits into from
Apr 10, 2012
Merged

Bigdecimal dup #5800

merged 3 commits into from
Apr 10, 2012

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented Apr 10, 2012

in master 440559f

@jeremy
Copy link
Member

jeremy commented Apr 10, 2012

Please cherry-pick 440559f from master instead of duplicating the commit.

Should 378ac86225c318c756a7de37db22c25330813557 be applied to master first?

@arunagw
Copy link
Member Author

arunagw commented Apr 10, 2012

@jeremy thanks. I done. Got conflicts in 440559f But now resolved.

thanks :-)

jeremy added a commit that referenced this pull request Apr 10, 2012
Backport BigDecimal#duplicable? feature check from master
@jeremy jeremy merged commit e0fd4fc into rails:3-2-stable Apr 10, 2012
@tenderlove
Copy link
Member

Are we going to support Ruby 2.0 on 3-2-stable? I mean, I use it, but not in production. :-/

Also I think we have a few other commits that will need backporting.

@jeremy
Copy link
Member

jeremy commented Apr 10, 2012

If it doesn't hurt (much), hell yeah

@tenderlove
Copy link
Member

So far it's only respond_to? changes. Need to find the commits though.

@arunagw
Copy link
Member Author

arunagw commented Apr 11, 2012

I think we should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants