Tiny refactoring in NumberHelper and RecordTagHelper #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lest
commented
Apr 26, 2012
lest
commented
- use safe_join in number helper
- refactor content_tag_for helper:
- do not use merge! just for 2 values
- there is no need to check block arity
- do not use merge! just for 2 values - there is no need to check block arity
|
I'm not sure if removing arity check is a good idea though. If people somehow calling |
|
@sikachu It should not raise an exception because block is not a lambda and doesn't check argument count |
jeremy
added a commit
that referenced
this pull request
Apr 26, 2012
Tiny refactoring in NumberHelper and RecordTagHelper
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.