Cover Rails::DBConsole with tests #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ENV['PGPORT'] = config["port"].to_s if config["port"] | ||
| ENV['PGPASSWORD'] = config["password"].to_s if config["password"] && include_password | ||
| exec(find_cmd('psql'), config["database"]) | ||
| set_env('PGUSER', config["username"]) if config["username"] |
There was a problem hiding this comment.
Why extract this method? If all that it will do is assign a hash key to a value I prefer the see the assignment.
|
Rafael, thanks you for the feedback. I applied your fixes, rebased and checked the test. |
drogus
added a commit
that referenced
this pull request
May 3, 2012
Cover Rails::DBConsole with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Rails::DBConsole. I tried to not modify original code, but I should add such changes:
find_cmdfrom body ofstartmethod (I think to put one method to another was just misprint)ENVchanges (to not polute ENV in tests)execI executed all tests also and checked
rails dbwith edge rails works well.\cc @drogus
Piotr, I see that you covered Rails::Console with tests. What do you think about my commit? I want to suggest some fix in Rails commands, but it's better to test existing code before. If it looks fine I'll add tests for all commands also.