Restore state on create when ActiveRecord::RecordInvalid is raised #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tenderlove |
|
👍 |
|
No comment or activity for 3 months. Change looks good to me, are there any complications that would prevent it from being merged in? |
|
@daveyeu could you add a CHANGELOG entry. I'll merge this one. |
ghost
assigned 
|
There ya go @rafaelfranca, thanks! |
|
uh oh, this needs a rebase! Darn CHANGELOGs. |
|
Do you mean I should squash the commits? Or rebase against rails HEAD? Or both? Sorry, not too familiar with the protocol, and I hate to force push anything that's public, but I'm happy to if that's the way it goes. |
|
We need a rebase against master. But rebase + squash would be better. |
|
Ok, rebased and squashed. Rakes green against master too. |
rafaelfranca
added a commit
that referenced
this pull request
Aug 12, 2012
Restore state on create when ActiveRecord::RecordInvalid is raised
|
Done. Thank you |
rafaelfranca
added a commit
that referenced
this pull request
Aug 12, 2012
Restore state on create when ActiveRecord::RecordInvalid is raised Conflicts: activerecord/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3217.
Previously, a call to AR#create that raised AR::RecordInvalid would leave a record in an inconsistent state -- it wouldn't actually be saved in the database, but #persisted? => true and #id would be non-nil. This patch also merges clean into 3-2-stable, for now.