Fix issue with private kernel methods and collection associations #6134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oses rails#2508 Change CollectionProxy#method_missing to use scoped.public_send, to avoid a problem described in issue rails#2508 when trying to use class methods with names like "open", that clash with private kernel methods. Also changed the dynamic matcher instantiator to send straight to scoped, to avoid another roundtrip to method_missing.
|
@jonleighton can you take a look on this one, if I'm not missing anything? Thanks. |
jonleighton
added a commit
that referenced
this pull request
May 3, 2012
…-private-methods Fix issue with private kernel methods and collection associations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CollectionProxy#method_missing to use scoped.public_send, to avoid a
problem described in issue #2508 when trying to use class methods with names
like "open", that clash with private kernel methods. Also changed the dynamic
matcher instantiator to send straight to scoped, to avoid another roundtrip
to method_missing.