Allows assert_redirected_to to accept a regular expression #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous discussion at #3792. I had deleted my fork since then, so couldn't force push it. |
| @controller.url_for(fragment) | ||
| end.delete("\0\r\n") | ||
| normalized = case fragment | ||
| when Regexp |
There was a problem hiding this comment.
I think in Rails we don't indent the case like this, but instead we simply do:
normalize = case fragment
when Regexp
...
end
Could you please adjust?
|
@alindeman I like this! Could you please fix the issues commented above and ping me when you are done? Thanks! |
|
Thanks @josevalim. I think I've addressed all the comments. |
josevalim
added a commit
that referenced
this pull request
May 3, 2012
Allows assert_redirected_to to accept a regular expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few places where I really only care to assert that the URL matches a regular expression.
This patch allows it while keeping the semantics the same when a
StringorHashis passed toassert_redirected_to