Bring SqlByPassTest to light and fix broken tests #6136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jeremy |
|
Maybe @tenderlove can take a look. I believe he's the one who created these tests. |
|
/ping @rafaelfranca @tenderlove @jeremy :) |
|
I'm not sure a about the |
|
@rafaelfranca makes sense. Just brought |
|
could you squash the commits? |
…ted?` for SqlBypass as expected by tests and convert session_id to string before using on queries to get correct quotes on postgresql (avoid casting error).
|
@rafaelfranca sure. there you go. |
tenderlove
added a commit
that referenced
this pull request
May 16, 2012
Bring SqlByPassTest to light and fix broken tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test file
activerecord/test/cases/session_store/sql_bypass.rbwasn't sufixed by_test.rband so wasn't caught by the test suite.Also,
SqlBypassimplemented anew_record?interface while the tests where expecting it to offerpersisted?. Since this was part of a commit that was then reverted I wasn't sure which one was preferred. I went withpersisted?.And last but not least, forced session_id to be passed as a string to the sql queries since postgresql was complaining about type mismatch (string column vs integer value on where clause).
Cheers