allow the :converter Proc form composed_of to return nil #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to filter invalid input values before they are passed into the value-object (like empty strings). This behaviour is only relevant if the :allow_nil options is set to true. Otherwise you will get the resulting NoMethodError.
|
@rafaelfranca here is the new pull-request. |
|
+1 ... This should be marked with the "ActiveRecord" label. |
|
+1 |
|
FWIW, our use case here is to support nil with the money gem (which recommends using composed_of). |
|
@rafaelfranca any progress on this one? |
|
I'm not familiar with the Active Record internals. The implementation looks fine to me, but I don't want to get this without talk with @jonleighton or @tenderlove. I'll try to contact they today and give you an answer. |
tenderlove
added a commit
that referenced
this pull request
May 21, 2012
allow the :converter Proc form composed_of to return nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to filter invalid input values before they are passed
into the value-object (like empty strings). This behaviour is only relevant
if the :allow_nil options is set to true. Otherwise you will get
the resulting NoMethodError.
This pull-request is the same as #3421 but with the correct merge target.