Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby prof fixes #6305

Merged
merged 2 commits into from May 13, 2012
Merged

Ruby prof fixes #6305

merged 2 commits into from May 13, 2012

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented May 13, 2012

finally got green build with ruby-prof changes.

second commit fixes

/Users/arunagw/checkouts/rails/actionpack/lib/action_view/helpers/number_helper.rb:257:in `number_with_delimiter': undefined method `safe_join' for #<ActiveSupport::Testing::Performance::Metrics::Objects:0x007f97305de098> (NoMethodError)
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:242:in `format'
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:105:in `report'
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:91:in `run_profile'
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:45:in `block in run'
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:43:in `each'
    from /Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/performance.rb:43:in `run'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:787:in `block in _run_suite'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:780:in `map'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:780:in `_run_suite'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:770:in `block in _run_suites'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:770:in `map'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:770:in `_run_suites'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:746:in `_run_anything'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:909:in `run_tests'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:896:in `block in _run'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:895:in `each'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:895:in `_run'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:884:in `run'
    from /Users/arunagw/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/minitest/unit.rb:664:in `block in autorun'
[[:puke, [ApplicationTests::TestTest, "test_performance_test", #<MiniTest::Assertion: Run options: --seed 42815

`number_with_delimiter': undefined method 
`safe_join' for 
#<ActiveSupport::Testing::Performance::Metrics::Objects
carlosantoniodasilva added a commit that referenced this pull request May 13, 2012
@carlosantoniodasilva carlosantoniodasilva merged commit 60de801 into rails:master May 13, 2012
@carlosantoniodasilva
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants