Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord::Relation select problem #6364

Conversation

kot-begemot
Copy link

All klass.connection and @klass.connection are now just connection, which is delegated to klass. Tests are passing

@jeremy
Copy link
Member

jeremy commented May 17, 2012

Looks good. Please squash to one commit.

Transfering rest klass.connections to delegated connection inside AR::Relation
@kot-begemot
Copy link
Author

Done.

@kot-begemot
Copy link
Author

I think I used wrong naming so duplicate a problem. This fix was made to partially solve following issue #6331

@steveklabnik
Copy link
Member

Mentioning #6331 directly so GitHub links them.

@rafaelfranca
Copy link
Member

@kot-begemot is this also an issue in the master branch?

@kot-begemot
Copy link
Author

@rafaelfranca, unfortunately yes. Problem is that internally,inside Relation, in exec_queris, appears klass.find_by_sql(). I am now trying to get rid of this, moving find_by_sql method inside into Relation. Not sure whether this is the best idea. I just need to have independent connection all over Relation.

@steveklabnik, Thanks! =)

@kot-begemot kot-begemot closed this Aug 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants