remove side effects on :controller option in #url_for #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: If the :controller option in an url_for call contains a leading slash it will be removed, which causes side-effects: my_controller = '/Example' url_for(:controller => my_controller) puts my_controller # => 'Example' Resolution: The route-set does not directly manipulate the string passed into #url_for. It creates a copy without the leading slash if necessary.
|
your PR needs a rebase. Not sure why it's showing that it cannot merge automatically. |
|
👍 please rebase, ping us, and we will merge it straight away! |
|
sorry for bothering with the outdated patch. I updated the source and noticed, that the bug was already fixed in a different commit: beea9f5 |
|
This is not fixed in 3.2.9, though I can find the changed code in master and 3.2-stable branches. When will it be available? Sorry if I'm asking a wrong question I'm new to how Rails is released. |
|
@clee704 there's no specific release date for a new 3.2.x version yet. If you need that feature, I'd recommend bundling from github using 3-2-stable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
If the
:controlleroption in an url_for call contains a leading slash itwill be removed, which causes side-effects:
The side-effects then affect plugins like will_paginate, which store the options to pass to
url_forin an instance_variable. The functionality then breaks after the first call tourl_for.Resolution:
The route-set does not directly manipulate the string passed into
#url_for.It creates a copy without the leading slash if necessary.