Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs to CollectionProxy #6385

Closed
wants to merge 1 commit into from
Closed

add docs to CollectionProxy #6385

wants to merge 1 commit into from

Conversation

frodsan
Copy link
Contributor

@frodsan frodsan commented May 18, 2012

@frodsan
Copy link
Contributor Author

frodsan commented May 18, 2012

cc @jonleighton @vijaydev @fxn If this ok, i will remove the changes in docrails and are more docs here :).

@jonleighton
Copy link
Member

Looks good to me, but I will wait for @fxn and @vijaydev to weigh in if they have thoughts on this approach.

@drogus
Copy link
Member

drogus commented May 18, 2012

@frodsan there is also another method of adding docs to methods defined at runtime: 7dba512

@frodsan
Copy link
Contributor Author

frodsan commented May 18, 2012

@drogus nice, thanks. I will make the changes in docrails.

@frodsan
Copy link
Contributor Author

frodsan commented May 18, 2012

@frodsan frodsan closed this May 18, 2012
@jonleighton
Copy link
Member

TBH I prefer the explicit delegation version. It makes the arity of the delegation method explicit.

@frodsan
Copy link
Contributor Author

frodsan commented May 18, 2012

TBH i agree. It's up to you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants