Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Filter Methods #6409

Closed
wants to merge 1 commit into from
Closed

Refactor Filter Methods #6409

wants to merge 1 commit into from

Conversation

admtnnr
Copy link

@admtnnr admtnnr commented May 20, 2012

Changed AbstractController::Callbacks to use define_method when creating before_filter, after_filter, etc. instead of class_eval.

@drogus
Copy link
Member

drogus commented May 20, 2012

Thanks for pull request, but class_eval is used here to not use blocks, which is better for performance. If you think that this will not have any impact you can try to prepare benchmark to ensure there is no regressions. Otherwise I don't think that this can be merged.

@drogus drogus closed this May 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants