Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also convert ... #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| ## Rails 4.0.0 (unreleased) ## | |||
|
|
|||
| * Add `Hash#transform_keys` and `Hash#transform_keys!`. *Mark McSpadden* | |||
| * Add `Hash#transform_keys`, `Hash#transform_keys!`, `Hash#deep_transform_keys`, and `Hash#transform_keys!`. *Mark McSpadden* | |||
There was a problem hiding this comment.
The last one should be deep_transform_keys!
|
Nice! :) |
|
@lucashungaro - you did the hard part :) |
| # This includes the keys from the root hash and from all | ||
| # nested hashes. | ||
| def deep_stringify_keys! | ||
| def deep_transform_keys!(&block) | ||
| keys.each do |key| | ||
| val = delete(key) |
There was a problem hiding this comment.
what do you think about use a uniforma name to the value? In one methods is val in other is value
There was a problem hiding this comment.
Agreed. Fixed.
…rt deep_*_keys to use deep_transform_keys.
rafaelfranca
added a commit
that referenced
this pull request
May 23, 2012
Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also convert ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...deep_*_keys to use deep_transform_keys.
Generalizes the deep_stringify_keys and friends that were added by @lucashungaro.
Open to suggestions.