(Try again) Fix #5847 and #4045. #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ | |||
|
|
|||
| require APP_PATH | |||
| Rails.application.require_environment! | |||
| require "active_record/base" | |||
There was a problem hiding this comment.
We can't hardcode Active Record here. Maybe we can provide a hook named runner as we did for rake_tasks, console and so forth. You can find their implementation here:
https://github.com/rails/rails/blob/master/railties/lib/rails/railtie.rb#L136
WDYT? Thanks a lot :)
There was a problem hiding this comment.
I agree. I also searched runner method in rails/railties.rb :-)
I'm going to fix it.
Thanks.
|
@josevalim I updated this PR and added runner hook. |
senny
added a commit
that referenced
this pull request
Nov 25, 2014
[Rafael Mendonça França & Yves Senn] This require caused the `active_record.set_configs` initializer to run immediately, before `config/initializers`. This means that setting any configuration on `Rails.application.config.active_record` inside of an initializer had no effects when rails was loaded through `rake`. Introduced by #6518 /cc @rafaelfranca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous my fix was reverted (See 0a8aec2 ).
And on master, the AR::Base is already loaded durring initialization.
To resolve original issues and AR::Base loading problem, I added 3 commits.
First: I added a testcase for original issue.
Second: I changed the timing of AR::Base loading (some tests weren't success).
Third: I fixed original issues.
/cc @josevalim