a test case that ensures AR::Relation#merge can merge associations #6605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a tiny patch enabling
AR::Relation#merge
to accept a collection association instance.In AR 3 we need to call
scoped
like this, but I thought it could be done implicitly.So I finished writing my patch, rebased my patch against master, then noticed that this feature was already implemented in the series of
merge
refactoring done by @jonleightonI'm not sure whether this was intentional or not (because there's no explicit test case for this), but I love this feature to be officially supported. So let me push my test case alone.