+ ActiveRecord::Base#destroy! #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # and <tt>destroy!</tt> raises ActiveRecord::RecordNotSaved. See | ||
| # ActiveRecord::Callbacks for further details. | ||
| def destroy! | ||
| destroy or raise ActiveRecord::RecordNotDestroyed |
There was a problem hiding this comment.
Can we use ||? It is in Rails Code Guidelines to not use and and or. Thanks!
|
BTW, the commit also supplements the rdoc for |
|
Great, can we have a changelog entry as well please? |
|
Changelog entry added. |
| # | ||
| # There's a series of callbacks associated with <tt>destroy!</tt>. If | ||
| # the <tt>before_destroy</tt> callback return +false+ the action is cancelled | ||
| # and <tt>destroy!</tt> raises ActiveRecord::RecordNotSaved. See |
There was a problem hiding this comment.
Ops, just noticed the constant name is wrong here, should be ActiveRecord::RecordNotDestroyed, right?
There was a problem hiding this comment.
Ah, the pitfalls of copy-paste :-)
Fixed, thanks.
carlosantoniodasilva
added a commit
that referenced
this pull request
Jun 6, 2012
Add ActiveRecord::Base#destroy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save!and variants are super useful when we have some generic exception handler setup, for example withrescue_from, and we expect the operation to succeed.destroyactions would benefit the same way of adestroy!version in the same way (especially since they so often succeed).Doesn't it sound great too? destroy!